OHRI-1994 Add TB Program menu and tabs shell on the patient chart #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
suggested changes
Nov 21, 2023
| @@ -2,3 +2,41 @@ export const tuberclosisMeta = { | |||
| title: 'Tuberclosis', | |||
| slotName: 'tuberclosis-slot', | |||
| }; | |||
|
|
|||
| export const TbDashboardDMeta = { | |||
There was a problem hiding this comment.
Suggested change
| export const TbDashboardDMeta = { | |
| export const tbPatientChartMeta = { |
| @@ -2,3 +2,41 @@ export const tuberclosisMeta = { | |||
| title: 'Tuberclosis', | |||
There was a problem hiding this comment.
Please delete this. I had added it as a place holder
packages/esm-tb-app/src/index.ts
Outdated
| @@ -1,5 +1,12 @@ | |||
| import { defineConfigSchema, getAsyncLifecycle, getSyncLifecycle } from '@openmrs/esm-framework'; | |||
| import { createDashboardGroup, createDashboardLink } from '@openmrs/esm-patient-common-lib'; | |||
| import { | |||
| TbDashboardDMeta, | |||
There was a problem hiding this comment.
update this name after meta change
packages/esm-tb-app/src/routes.json
Outdated
| "name": "ohri-tb", | ||
| "slot": "patient-chart-dashboard-slot", | ||
| "component": "patientChartTbDashboard", | ||
| "order": 21 |
There was a problem hiding this comment.
Change this to 24 so that it appears HIV and COVID
Comment on lines
11
to
13
| const headerRecentTB = t('recentTuberculosis'); | ||
| const headerPreviousCases = t('previousCases'); | ||
| const headerVisit = t('visits'); |
There was a problem hiding this comment.
add default incase a translation doesn't exist for example we don't have translations for this in Amaric
Comment on lines
18
to
19
| <Tab>{t('MdrTbEnrolment')}</Tab> | ||
| <Tab>{t('PatientTracing')}</Tab> |
There was a problem hiding this comment.
Same comment applies here. Change all occurrences of this within this PR
Comment on lines
5
to
7
| interface TbTreatmentFollowUpListProps { | ||
| patientUuid: string; | ||
| } |
There was a problem hiding this comment.
Reuse the interface defined in the commons. I think it's PatientChartProps to avoid repetition
pirupius
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
OHRI-123 My PR title.Summary
Screenshots
Related Issue
Other